On Tue, 25 Feb 2025 at 16:31, Gerd Hoffmann <[email protected]> wrote: > > Signed-off-by: Gerd Hoffmann <[email protected]> > --- > docs/devel/index-internals.rst | 1 + > docs/devel/uefi-vars.rst | 68 ++++++++++++++++++++++++++++++++++ > hw/uefi/LIMITATIONS.md | 7 ++++ > 3 files changed, 76 insertions(+) > create mode 100644 docs/devel/uefi-vars.rst > create mode 100644 hw/uefi/LIMITATIONS.md
> +The ``uefi-vars`` device implements the UEFI virtual device. It comes > +in ``uefi-vars-x86`` and ``uefi-vars-sysbus`` flavours. Hi; a bug reporter points out that this documentation says the device name is uefi-vars-x86, but the code does #define TYPE_UEFI_VARS_X64 "uefi-vars-x64" https://gitlab.com/qemu-project/qemu/-/issues/3106 I guess we need to update the docs? > +The advantage of the approach is that we do not need a special > +privilege level for the firmware to protect itself, i.e. it does not > +depend on SMM emulation on x64 Our name for the 64-bit intel architecture is "x86_64"; we should use that consistently, not "x64". (Ideally we would also have been consistent in the device name, but it's been released now...) thanks -- PMM
