Re: [PATCH v3 02/14] hw/pci-host/raven: Simplify host bridge type declaration

Thu, 18 Sep 2025 12:16:35 -0700 

On 18/09/2025 19:50, BALATON Zoltan wrote:


Use OBJECT_DECLARE_SIMPLE_TYPE macro instead of open coding it.

Signed-off-by: BALATON Zoltan <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
---
  hw/pci-host/raven.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index 172f01694c..878c915de5 100644
--- a/hw/pci-host/raven.c
+++ b/hw/pci-host/raven.c
@@ -39,11 +39,9 @@
  #define TYPE_RAVEN_PCI_DEVICE "raven"
  #define TYPE_RAVEN_PCI_HOST_BRIDGE "raven-pcihost"
-typedef struct PRePPCIState PREPPCIState; 
-DECLARE_INSTANCE_CHECKER(PREPPCIState, RAVEN_PCI_HOST_BRIDGE,
-                         TYPE_RAVEN_PCI_HOST_BRIDGE)
+OBJECT_DECLARE_SIMPLE_TYPE(PREPPCIState, RAVEN_PCI_HOST_BRIDGE)
-struct PRePPCIState { 
+struct PREPPCIState {
      PCIHostState parent_obj;
OrIRQState *or_irq; 

Possibly worth mentioning the change of case for PREPPCIState? Otherwise:

Reviewed-by: Mark Cave-Ayland <[email protected]>


ATB,

Mark.

Reply via email to