Please send all patches to qemu-devel@ (CC'ed), not just qemu-trivial@, --
the same as for previous one.
On 15.09.2025 21:07, ShengYi Hung wrote:
According to Intel 6300ESB Controller Hub Datasheet 14.4.15, the interrupt
Which datasheet you refer to here?
type mask should be 0x03 (0b11) instead of 0x11. In the original
implementation, when we want to disable all interrupt by setting the
value to 0x03, we will get 0x01 which is incorrect when we want to read
the value again. However, there is no problem whe considering the correct
behavior
since 0x01 is reserved and unused just like 0x03. This patch is just a
fix to return the register value.
Applying to the trivial-patches tree, with spelling fix for the patch
description.
Thanks,
/mjt
Signed-off-by: ShengYi Hung <aokbl...@freebsd.org>
---
hw/watchdog/wdt_i6300esb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index bb8a2766b6..3aa01b8d68 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -55,7 +55,7 @@
/* Config register bits */
#define ESB_WDT_REBOOT (0x01 << 5) /* Enable reboot on timeout */
#define ESB_WDT_FREQ (0x01 << 2) /* Decrement frequency */
-#define ESB_WDT_INTTYPE (0x11 << 0) /* Interrupt type on timer1 timeout */
+#define ESB_WDT_INTTYPE (0x03 << 0) /* Interrupt type on timer1 timeout */
/* Reload register bits */
#define ESB_WDT_RELOAD (0x01 << 8) /* prevent timeout */
