On Wed, Sep 17, 2025 at 01:13:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 16.09.25 18:50, Daniel P. Berrangé wrote: > > On Tue, Sep 16, 2025 at 04:14:02PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 1. Drop extra error_report_err(NULL), it will just crash, if we get > > > here. > > > > > > 2. Get and report error of qemu_set_blocking(), instead of aborting. > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > > > --- > > > util/vhost-user-server.c | 17 +++++++++++------ > > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé <[email protected]> > > > > Thanks a lot! > > Now the whole series is reviewed. Will you queue it > (together with base "[PATCH v4 0/2] save qemu-file incoming non-blocking > fds")? > Or we should wait for ACCs from other maintainers?
I'm queuing it, with fixes for the minor problems I pointed out. If possible, try to feed big patch series through gitlab.com CI in your own qemu.git fork before sending to catch all edge cases. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
