On Tue, Sep 16, 2025 at 12:58:24PM +0300, Manos Pitsidianakis wrote:
> Date: Tue, 16 Sep 2025 12:58:24 +0300
> From: Manos Pitsidianakis <[email protected]>
> Subject: Re: [PATCH 01/12] subprojects: Update .gitignore for proc-macro2
>  and syn
> 
> On Tue, Sep 16, 2025 at 11:34 AM Zhao Liu <[email protected]> wrote:
> >
> > Signed-off-by: Zhao Liu <[email protected]>
> > ---
> >  subprojects/.gitignore | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> > index f4281934ce11..9d579f72d121 100644
> > --- a/subprojects/.gitignore
> > +++ b/subprojects/.gitignore
> > @@ -16,7 +16,7 @@
> >  /libc-0.2.162
> >  /proc-macro-error-1.0.4
> >  /proc-macro-error-attr-1.0.4
> > -/proc-macro2-1.0.84
> > +/proc-macro2-1.0.95
> >  /quote-1.0.36
> > -/syn-2.0.66
> > +/syn-2.0.104
> >  /unicode-ident-1.0.12
> > --
> > 2.34.1
> >
> 
> Reviewed-by: Manos Pitsidianakis <[email protected]>

Thanks!

> Maybe we could change the entries to match any directory with a version, e.g.
> 
> /proc-macro2-[0-9.]*/

Here I prefer exact matching, as it allows for timely cleanup of outdated
subprojects.

Regards,
Zhao


Reply via email to