Filip Hejsek <[email protected]> writes:
> On Mon, 2025-09-22 at 08:45 +0200, Markus Armbruster wrote:
>> Filip Hejsek <[email protected]> writes:
>>
>> > From: Szymon Lukasz <[email protected]>
>> >
>> > The managment software can use this command to notify QEMU about the
>> > size of the terminal connected to a chardev, QEMU can then forward this
>> > information to the guest if the chardev is connected to a virtio console
>> > device.
>> >
>> > Signed-off-by: Szymon Lukasz <[email protected]>
>> > Suggested-by: Daniel P. Berrangé <[email protected]>
>> > [Filip: rename command, change documentation]
>> > Signed-off-by: Filip Hejsek <[email protected]>
[...]
>> > diff --git a/qapi/char.json b/qapi/char.json
>> > index
>> > f0a53f742c8bee24c377551803a864fd36ac78cf..93b0d239276077d808af2e5479d539728377a99f
>> > 100644
>> > --- a/qapi/char.json
>> > +++ b/qapi/char.json
>> > @@ -874,6 +874,36 @@
>> > { 'command': 'chardev-send-break',
>> > 'data': { 'id': 'str' } }
>> >
>> > +##
>> > +# @chardev-window-size-changed:
>> > +#
>> > +# Notifies a chardev about the current size of the terminal connected
>> > +# to this chardev. The information will be forwarded to the guest if
>> > +# the chardev is connected to a virtio console device.
>> > +#
>> > +# The initial size is 0x0, which should be interpreted as an unknown size.
>> > +#
>> > +# Some backends detect the terminal size automatically, in which case
>> > +# the size may unpredictably revert to the detected one at any time.
>>
>> Nicely done now!
>>
>> docs/devel/qapi-code-gen.rst:
>>
>> For legibility, wrap text paragraphs so every line is at most 70
>> characters long.
>>
>> Separate sentences with two spaces.
>>
>> > +#
>> > +# @id: the chardev's ID, must exist
>>
>> Let's drop ", must exist" for consistency with ID descriptions
>> elsewhere.
>
> All chardev @id parameters in qapi/char.json have ", must exist"
> (although you're right that nothing else has it).
Right. Feel free to stay locally consistent then.
[...]
