On 07/06/25 4:34 PM, Aditya Gupta wrote:
Note: No changes, only change compared to v6 is rebased to upstream

Power8E and Power8NVL are not maintained, and not useful to qemu, and
upstream skiboot also has removed support till Power8 DD1.
Power8NVL CPU doesn't boot since skiboot v7.0, or following skiboot commit
to be exact:

     commit c5424f683ee3 ("Remove support for POWER8 DD1")

No direct way to deprecate the pnv chips, a field like deprecation_note
could be added, but felt not needed as the chip will only get used if
the user requests corresponding 8E / 8NVL CPU, which will print
deprecation warning.

Also, no separate pnv machine for 8E and 8NVL, user has to pass --cpu,
which will throw the deprecation warning. So just deprecating CPUs should
be enough.

Changelog
=========
v7:
   + rebased to upstream
v6:
   + change qemu version from 10.0 to 10.1 in doc
v5 
(https://lore.kernel.org/qemu-devel/[email protected]/):
   + split into 2 patches, defining macro, and deprecating 8e & 8nvl
v4 
(https://lore.kernel.org/qemu-devel/[email protected]/):
   + remove unnecessary 'if'
v3:
   + add 'deprecation_note' argument to the POWERPC_DEPRECATED_CPU macro
v2:
   + add mention to docs/about/deprecated.rst
   + add '(deprecated)' in output of qemu-system-ppc64 --cpu help

Base Commit: 96215036f47403438c7c7869b7cd419bd7a11f82

Aditya Gupta (2):
   target/ppc: Introduce macro for deprecating PowerPC CPUs
   target/ppc: Deprecate Power8E and Power8NVL

  docs/about/deprecated.rst |  9 +++++++++
  target/ppc/cpu-models.c   | 20 +++++++++++++++-----
  target/ppc/cpu_init.c     |  7 ++++++-
  3 files changed, 30 insertions(+), 6 deletions(-)


Hi Aditya,

I have tested this patch, it is giving proper mention as deprecated
for the CPU model Power8E and Power8NVL and  here is my observation:

Without the patch it is not showing any cpu-model as deprecated

# qemu-system-ppc64 --cpu help | grep power8
  power8e_v2.1     PVR 004b0201
  power8e          (alias for power8e_v2.1)
  power8nvl_v1.0   PVR 004c0100
  power8nvl        (alias for power8nvl_v1.0)
  power8_v2.0      PVR 004d0200
  power8           (alias for power8_v2.0)


# qemu-system-ppc64 --cpu help | grep deprecated
No output for this


After applying the patch
# ./qemu-system-ppc64 --cpu help | grep deprecated
 power8e_v2.1   PVR 004b0201 (deprecated)
 power8nvl_v1.0  PVR 004c0100 (deprecated)


# ./qemu-system-ppc64 --cpu help | grep power8
  power8e_v2.1     PVR 004b0201 (deprecated)
  power8e          (alias for power8e_v2.1)
  power8nvl_v1.0   PVR 004c0100 (deprecated)
  power8nvl        (alias for power8nvl_v1.0)
  power8_v2.0      PVR 004d0200
  power8           (alias for power8_v2.0)

Tested-by: Anushree Mathur <[email protected]>

Reply via email to