Re: [PATCH v2 07/12] linux-user: Use tb_flush_exclusive to start second thread

[Philippe Mathieu-Daudé]

On 23/9/25 04:39, Richard Henderson wrote:

When we start the second thread, we discard all translations
so that we can re-do them with CF_PARALLEL.  Since there is
as yet only one cpu, and we are processing a syscall, there
are no live translation blocks and we have exclusivity.

Maybe factor out a helper expressing that? (can be done on top,
of course).

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  linux-user/mmap.c    | 4 ++--
  linux-user/syscall.c | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 002e1e668e..bd2bbaf1f4 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -1010,7 +1010,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int 
target_prot,
          CPUState *cpu = thread_cpu;
          if (!tcg_cflags_has(cpu, CF_PARALLEL)) {
              tcg_cflags_set(cpu, CF_PARALLEL);
-            tb_flush(cpu);
+            tb_flush__exclusive();
          }
      }

@@ -1450,7 +1450,7 @@ abi_ulong target_shmat(CPUArchState *cpu_env, int shmid,

       */
      if (!tcg_cflags_has(cpu, CF_PARALLEL)) {
          tcg_cflags_set(cpu, CF_PARALLEL);
-        tb_flush(cpu);
+        tb_flush__exclusive();
      }

if (qemu_loglevel_mask(CPU_LOG_PAGE)) {

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 91360a072c..d9c394856f 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6633,7 +6633,7 @@ static int do_fork(CPUArchState *env, unsigned int flags, 
abi_ulong newsp,
           */
          if (!tcg_cflags_has(cpu, CF_PARALLEL)) {
              tcg_cflags_set(cpu, CF_PARALLEL);
-            tb_flush(cpu);
+            tb_flush__exclusive();
          }

/* we create a new CPU instance. */