Re: [PATCH v2 2/7] hw/arm/aspeed: Move write_boot_rom to common SoC code

[Cédric Le Goater]

On 9/24/25 07:55, Jamin Lin wrote:

Move the write_boot_rom helper from hw/arm/aspeed.c into
hw/arm/aspeed_soc_common.c so it can be reused by all ASPEED
machines. Export the API as aspeed_write_boot_rom() in
include/hw/arm/aspeed_soc.h and update the existing call site
to use the new helper.

No functional change.

Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  include/hw/arm/aspeed_soc.h |  2 ++
  hw/arm/aspeed.c             | 33 ++-------------------------------
  hw/arm/aspeed_soc_common.c  | 31 +++++++++++++++++++++++++++++++
  3 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index aaf518d179..5567bdcb69 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -312,6 +312,8 @@ void aspeed_mmio_map_unimplemented(AspeedSoCState *s, 
SysBusDevice *dev,
                                     uint64_t size);
  void aspeed_board_init_flashes(AspeedSMCState *s, const char *flashtype,
                                 unsigned int count, int unit0);
+void aspeed_write_boot_rom(BlockBackend *blk, hwaddr addr, size_t rom_size,
+                           Error **errp);

static inline int aspeed_uart_index(int uart_dev)

  {
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 55f0afe0a4..4d0d935836 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -263,35 +263,6 @@ static void aspeed_reset_secondary(ARMCPU *cpu,
      cpu_set_pc(cs, info->smp_loader_start);
  }

-static void write_boot_rom(BlockBackend *blk, hwaddr addr, size_t rom_size,

-                           Error **errp)
-{
-    g_autofree void *storage = NULL;
-    int64_t size;
-
-    /*
-     * The block backend size should have already been 'validated' by
-     * the creation of the m25p80 object.
-     */
-    size = blk_getlength(blk);
-    if (size <= 0) {
-        error_setg(errp, "failed to get flash size");
-        return;
-    }
-
-    if (rom_size > size) {
-        rom_size = size;
-    }
-
-    storage = g_malloc0(rom_size);
-    if (blk_pread(blk, 0, rom_size, storage, 0) < 0) {
-        error_setg(errp, "failed to read the initial flash content");
-        return;
-    }
-
-    rom_add_blob_fixed("aspeed.boot_rom", storage, rom_size, addr);
-}
-
  /*
   * Create a ROM and copy the flash contents at the expected address
   * (0x0). Boots faster than execute-in-place.
@@ -306,8 +277,8 @@ static void aspeed_install_boot_rom(AspeedMachineState 
*bmc, BlockBackend *blk,
                             &error_abort);
      memory_region_add_subregion_overlap(&soc->spi_boot_container, 0,
                                          &bmc->boot_rom, 1);
-    write_boot_rom(blk, sc->memmap[ASPEED_DEV_SPI_BOOT],
-                   rom_size, &error_abort);
+    aspeed_write_boot_rom(blk, sc->memmap[ASPEED_DEV_SPI_BOOT], rom_size,
+                          &error_abort);
  }

#define VBOOTROM_FILE_NAME "ast27x0_bootrom.bin"

diff --git a/hw/arm/aspeed_soc_common.c b/hw/arm/aspeed_soc_common.c
index 31b1e683c3..d0a400725f 100644
--- a/hw/arm/aspeed_soc_common.c
+++ b/hw/arm/aspeed_soc_common.c
@@ -17,6 +17,8 @@
  #include "hw/arm/aspeed_soc.h"
  #include "hw/char/serial-mm.h"
  #include "system/blockdev.h"
+#include "system/block-backend.h"
+#include "hw/loader.h"

const char *aspeed_soc_cpu_type(AspeedSoCClass *sc)

@@ -147,6 +149,35 @@ void aspeed_board_init_flashes(AspeedSMCState *s, const 
char *flashtype,
      }
  }

+void aspeed_write_boot_rom(BlockBackend *blk, hwaddr addr, size_t rom_size,

+                           Error **errp)
+{
+    g_autofree void *storage = NULL;
+    int64_t size;
+
+    /*
+     * The block backend size should have already been 'validated' by
+     * the creation of the m25p80 object.
+     */
+    size = blk_getlength(blk);
+    if (size <= 0) {
+        error_setg(errp, "failed to get flash size");
+        return;
+    }
+
+    if (rom_size > size) {
+        rom_size = size;
+    }
+
+    storage = g_malloc0(rom_size);
+    if (blk_pread(blk, 0, rom_size, storage, 0) < 0) {
+        error_setg(errp, "failed to read the initial flash content");
+        return;
+    }
+
+    rom_add_blob_fixed("aspeed.boot_rom", storage, rom_size, addr);
+}
+
  static void aspeed_soc_realize(DeviceState *dev, Error **errp)
  {
      AspeedSoCState *s = ASPEED_SOC(dev);