On 28/08/2025 04:59, Peter Xu wrote:
> The rdmaout should be a cache of rioc->rdmaout, not rioc->rdmain.
> 
> Cc: Zhijian Li (Fujitsu) <[email protected]>
> Cc: Lidong Chen <[email protected]>
> Fixes: 54db882f07 ("migration: implement the shutdown for RDMA QIOChannel")
> Signed-off-by: Peter Xu <[email protected]>

Good catch.

Reviewed-by: Li Zhijian <[email protected]>


> ---
>   migration/rdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 2d839fce6c..e6837184c8 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -2986,7 +2986,7 @@ qio_channel_rdma_shutdown(QIOChannel *ioc,
>       RCU_READ_LOCK_GUARD();
>   
>       rdmain = qatomic_rcu_read(&rioc->rdmain);
> -    rdmaout = qatomic_rcu_read(&rioc->rdmain);
> +    rdmaout = qatomic_rcu_read(&rioc->rdmaout);
>   
>       switch (how) {
>       case QIO_CHANNEL_SHUTDOWN_READ:

Reply via email to