On Wed, Oct 01, 2025 at 01:17:44PM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 16, 2025 at 06:48:45PM +0200, Magnus Kulke wrote:
> > -    mshv_arch_init_vcpu(cpu);
> >      cpu->accel = g_new0(AccelCPUState, 1);
> > +    mshv_arch_init_vcpu(cpu);
>
> This change can either be dropped, or squashed into the
> earlier patch in this series that introduced this method.
>

right, this makes sense.

> > +#define MAX_SIZE(a, b) ((a) > (b) ? (a) : (b))
>
> Isn't this the same as the existing 'MAX(a, b)' macro in osdep.h ?
>

not quite, I don't think MAX can be used in a static assertion, but
there's a MAX_CONST sibling that we can use.

Reply via email to