On Tue, Sep 30, 2025 at 03:53:51PM +0800, Zhao Liu wrote:
> The commit a530a8d4ac39 missed to update syn version, this is because
> the code base of its v2 patch has fixed syn version, so that the fix for
> syn were lost during the rebase from v1 to v2.
> 
> To rectify this mistake, update the syn version.
> 
> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
> Signed-off-by: Zhao Liu <[email protected]>
> ---
>  subprojects/.gitignore | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> index 58a29f012044..136e30cd99ad 100644
> --- a/subprojects/.gitignore
> +++ b/subprojects/.gitignore
> @@ -19,7 +19,7 @@
>  /proc-macro-error-attr-1.0.4
>  /proc-macro2-1.0.95
>  /quote-1.0.36
> -/syn-2.0.66
> +/syn-2.0.104
>  /unicode-ident-1.0.12

IMHO we should get rid of all the version numbers, and use wildcard
matches instead, to eliminate the bug scenario entirely, as people
will repeatedly forgot to change these versions.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Reply via email to