On 02/10/25, Pierrick Bouvier wrote:
> On 10/1/25 12:33 AM, Anton Johansson wrote:
> > All debug.h definitions except for RV_MAX_TRIGGERS are internal to
> > target/riscv.  Move RV_MAX_TRIGGERS to cpu.h and include debug.h from
> > all translation units which relied on the cpu.h include.
> > 
> > Signed-off-by: Anton Johansson <[email protected]>
> > ---
> >   target/riscv/cpu.h         | 4 ++--
> >   target/riscv/debug.h       | 2 --
> >   target/riscv/cpu.c         | 3 +++
> >   target/riscv/csr.c         | 3 +++
> >   target/riscv/debug.c       | 1 +
> >   target/riscv/tcg/tcg-cpu.c | 1 +
> >   6 files changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> > index a53981a09b..70e0f3718c 100644
> > --- a/target/riscv/cpu.h
> > +++ b/target/riscv/cpu.h
> > @@ -177,14 +177,14 @@ extern RISCVCPUImpliedExtsRule 
> > *riscv_multi_ext_implied_rules[];
> >   #define MAX_RISCV_PMPS (64)
> >   #define OLD_MAX_RISCV_PMPS (16)
> > -#if !defined(CONFIG_USER_ONLY)
> > +#if !defined(CONFIG_LINUX_USER)
> 
> Squashed from another change?
> 
> ...
> 
> Reviewed-by: Pierrick Bouvier <[email protected]>

Yup, nice catch!

Reply via email to