On Thu, Sep 04, 2025 at 04:27:39PM +0800, Zhang Chen wrote: > > I confess I didn't test anything on COLO but only from code observations > > and analysis. COLO maintainers: could you add some unit tests to QEMU's > > qtests? > > For the COLO part, I think remove the coroutines related code is OK for me. > Because the original coroutine still need to call the > "colo_process_incoming_thread".
Chen, thanks for the comment. It's still reassuring. > > Hi Hailiang, any comments for this part? Any further comment on this series would always be helpful. It'll be also great if anyone can come up with a selftest for COLO. Now any new migration features needs both unit test and doc to get merged. COLO was merged earlier so it doesn't need to, however these will be helpful for sure to make sure COLO won't be easily broken. Thanks, -- Peter Xu
