Am 01.07.2025 um 13:44 hat Hanna Czenczek geschrieben: > There is no clear separation between what should go into > setup_fuse_export() and what should stay in fuse_export_create(). > > Make it clear that setup_fuse_export() is for mounting only. Rename it, > and move everything that has nothing to do with mounting up into > fuse_export_create(). > > Reviewed-by: Stefan Hajnoczi <[email protected]> > Signed-off-by: Hanna Czenczek <[email protected]> > --- > block/export/fuse.c | 49 ++++++++++++++++++++------------------------- > 1 file changed, 22 insertions(+), 27 deletions(-) > > diff --git a/block/export/fuse.c b/block/export/fuse.c > index 60d68d8fdd..01a5716bdd 100644 > --- a/block/export/fuse.c > +++ b/block/export/fuse.c
> + g_hash_table_insert(exports, g_strdup(exp->mountpoint), NULL); > + > + aio_set_fd_handler(exp->common.ctx, > + fuse_session_fd(exp->fuse_session), > + read_from_fuse_export, NULL, NULL, NULL, exp); > + exp->fd_handler_set_up = true; > + Preexisting, but 'exports' is really a bad name for a global variable in QEMU. Maybe we should rename it to 'fuse_exports' on top of the series. Kevin
