On 17/10/2025 15.40, Philippe Mathieu-Daudé wrote:
On 17/10/25 15:38, Thomas Huth wrote:
On 17/10/2025 15.29, Philippe Mathieu-Daudé wrote:
Remove the deprecated s390-ccw-virtio-4.2 up to 7.2 machines,
which are older than 6 years. Remove resulting dead code.

Philippe Mathieu-Daudé (12):
   hw/s390x/ccw: Remove deprecated s390-ccw-virtio-4.2 machine
   hw/s390x/ccw: Remove SCLPDevice::increment_size field

NACK.

Being deprecated does not mean that the deprecation period already expired.
Please re-read the paragraph about machine deprecation in docs/about/ deprecated.rst carefully again.

Yes, my bad, I misunderstood the '-M help' output.

Still, please consider the first 2 patches (4.2 is over 6yo).

Agreed, 4.2 can be removed. But in that case, please add a 3rd patch that also removes the fixup_ram_size stuff from hw/core/machine.c since s390x was the last user.

 Thanks,
  Thomas


Reply via email to