Philippe Mathieu-Daudé <[email protected]> writes:
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> Reviewed-by: Richard Henderson <[email protected]>
> ---
> accel/tcg/tcg-accel-ops.c | 2 --
> system/cpus.c | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c
> index b24d6a75625..6116644d1c0 100644
> --- a/accel/tcg/tcg-accel-ops.c
> +++ b/accel/tcg/tcg-accel-ops.c
> @@ -93,8 +93,6 @@ static void tcg_cpu_reset_hold(CPUState *cpu)
> /* mask must never be zero, except for A20 change call */
> void tcg_handle_interrupt(CPUState *cpu, int mask)
> {
> - g_assert(bql_locked());
> -
> cpu->interrupt_request |= mask;
>
> /*
> diff --git a/system/cpus.c b/system/cpus.c
> index d16b0dff989..a43e0e4e796 100644
> --- a/system/cpus.c
> +++ b/system/cpus.c
> @@ -265,6 +265,8 @@ static void generic_handle_interrupt(CPUState *cpu, int
> mask)
>
> void cpu_interrupt(CPUState *cpu, int mask)
> {
> + g_assert(bql_locked());
> +
Is this really the case since 27e76d01010 (cpu-common: use atomic access
for interrupt_request). In fact I think tcg_handle_interrupt now uses
cpu_set_interrupt.
> if (cpus_accel->handle_interrupt) {
> cpus_accel->handle_interrupt(cpu, mask);
> } else {
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
