Re: [PATCH 3/8] target/rx: Propagate DisasContext to generated helpers

[Richard Henderson]

On 10/9/25 08:16, Philippe Mathieu-Daudé wrote:

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  target/rx/translate.c | 24 ++++++++++++------------
  1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/target/rx/translate.c b/target/rx/translate.c
index 9a2be2107bd..f02a8cc5dc9 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -1894,7 +1894,7 @@ static bool trans_ITOF(DisasContext *ctx, arg_ITOF * a)
      return true;
  }

-static void rx_bsetm(TCGv mem, TCGv mask)

+static void rx_bsetm(DisasContext *ctx, TCGv mem, TCGv mask)
  {
      TCGv val;
      val = tcg_temp_new();
@@ -1903,7 +1903,7 @@ static void rx_bsetm(TCGv mem, TCGv mask)
      rx_gen_st(MO_8, val, mem);
  }

-static void rx_bclrm(TCGv mem, TCGv mask)

+static void rx_bclrm(DisasContext *ctx, TCGv mem, TCGv mask)
  {
      TCGv val;
      val = tcg_temp_new();
@@ -1912,7 +1912,7 @@ static void rx_bclrm(TCGv mem, TCGv mask)
      rx_gen_st(MO_8, val, mem);
  }

-static void rx_btstm(TCGv mem, TCGv mask)

+static void rx_btstm(DisasContext *ctx, TCGv mem, TCGv mask)
  {
      TCGv val;
      val = tcg_temp_new();
@@ -1922,7 +1922,7 @@ static void rx_btstm(TCGv mem, TCGv mask)
      tcg_gen_mov_i32(cpu_psw_z, cpu_psw_c);
  }

-static void rx_bnotm(TCGv mem, TCGv mask)

+static void rx_bnotm(DisasContext *ctx, TCGv mem, TCGv mask)
  {
      TCGv val;
      val = tcg_temp_new();
@@ -1931,17 +1931,17 @@ static void rx_bnotm(TCGv mem, TCGv mask)
      rx_gen_st(MO_8, val, mem);
  }

-static void rx_bsetr(TCGv reg, TCGv mask)

+static void rx_bsetr(DisasContext *ctx, TCGv reg, TCGv mask)
  {
      tcg_gen_or_i32(reg, reg, mask);
  }

-static void rx_bclrr(TCGv reg, TCGv mask)

+static void rx_bclrr(DisasContext *ctx, TCGv reg, TCGv mask)
  {
      tcg_gen_andc_i32(reg, reg, mask);
  }

-static inline void rx_btstr(TCGv reg, TCGv mask)

+static inline void rx_btstr(DisasContext *ctx, TCGv reg, TCGv mask)
  {
      TCGv t0;
      t0 = tcg_temp_new();
@@ -1950,7 +1950,7 @@ static inline void rx_btstr(TCGv reg, TCGv mask)
      tcg_gen_mov_i32(cpu_psw_z, cpu_psw_c);
  }

-static inline void rx_bnotr(TCGv reg, TCGv mask)

+static inline void rx_bnotr(DisasContext *ctx, TCGv reg, TCGv mask)
  {
      tcg_gen_xor_i32(reg, reg, mask);
  }

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

These really shouldn't be marked inline, but that's another issue.


r~