On Fri, Sep 19, 2025 at 04:44:34PM -0500, Tom Lendacky wrote: > On 9/18/25 05:27, Naveen N Rao (AMD) wrote: > > Now that users can enable VMSA SEV features, update sev_init2_required() > > to return true if any SEV features are requested. This enables qemu to > > use KVM_SEV_INIT2 for SEV-ES guests when necessary. > > > > Sample command-line: > > -machine q35,confidential-guest-support=sev0 \ > > -object > > sev-guest,id=sev0,policy=0x5,cbitpos=51,reduced-phys-bits=1,debug-swap=on > > > > Should this patch go before patch #5 from a bisect point of view? Because > won't patch #5 fail because you still aren't using init2?
I put this patch after the base debug-swap support since it is not possible to exercize this code otherwise. But, as you rightly point out, this just means that patch 5/8 is buggy and that is not good from a bisect standpoint. I will move this before patch 5/8. > > > Reviewed-by: Nikunj A Dadhania <[email protected]> > > Signed-off-by: Naveen N Rao (AMD) <[email protected]> > > Reviewed-by: Tom Lendacky <[email protected]> Thanks for the review, - Naveen
