>From qapi/error.h: * Please don't error_setg(&error_fatal, ...), use error_report() and * exit(), because that's more obvious. * Likewise, don't error_setg(&error_abort, ...), use assert().
Not mentioned, but just as undesirable: error_setg(&error_warn, ...). This series eliminates such uses, and gets rid of &error_warn. &error_warn has multiple issues and little use. PATCH 12 has full rationale. A note on warnings: we don't use warnings much, and when we use them, they're often pretty bad. See my memo "Abuse of warnings for unhandled errors and programming errors" Message-ID: <[email protected]> https://lore.kernel.org/qemu-devel/[email protected]/ v3: * PATCH 02: Whitespace cleanup [Akihiko Odaki] * PATCH 06+07: Memory leaks on error paths [Akihiko Odaki] * PATCH 08+13: Rebase conflicts * PATCH 12: New v2: * PATCH 03: Mention change of cxl_fmws_link() return value in commit message [Jonathan] * PATCH 04: Change exit(1) to g_assert_not_reached(), because it's a programming error. * PATCH 06+07: Replace questions in commit message by answers from review. * PATCH 06: Fix a format string * PATCH 08: Keep warnings instead of reverting to silence [Daniel] * PATCH 12: Adjusted for replaced PATCH 08 Issues raised in review I decided not to address in this series: * PATCH 03: messages could be improved further, in particular the "gdbstub: " prefix could be dropped * ebpf_rss_load() can return false without setting an error * Capture the discussion on how to deal with undhandled errors in cover letter and/or commit messages. The first two could be done on top. Markus Armbruster (13): monitor: Clean up HMP gdbserver error reporting tcg: Fix error reporting on mprotect() failure in tcg_region_init() hw/cxl: Convert cxl_fmws_link() to Error migration/cpr: Clean up error reporting in cpr_resave_fd() hw/remote/vfio-user: Clean up error reporting net/slirp: Clean up error reporting ui/spice-core: Clean up error reporting util/oslib-win32: Do not treat null @errp as &error_warn ui/pixman: Consistent error handling in qemu_pixman_shareable_free() ui/dbus: Clean up dbus_update_gl_cb() error checking ui/dbus: Consistent handling of texture mutex failure ivshmem-flat: Mark an instance of missing error handling FIXME error: Kill @error_warn include/exec/gdbstub.h | 3 --- include/qapi/error.h | 6 ------ include/system/os-win32.h | 5 ++++- hw/cxl/cxl-host.c | 7 ++++--- hw/display/virtio-gpu.c | 8 ++++++-- hw/misc/ivshmem-flat.c | 8 ++++++-- hw/net/virtio-net.c | 8 +++++++- hw/remote/vfio-user-obj.c | 9 +++------ io/channel-socket.c | 4 ++-- io/channel-watch.c | 6 +++--- migration/cpr.c | 9 +++++---- monitor/hmp-cmds.c | 7 ++++--- net/slirp.c | 9 +++++++-- tcg/region.c | 7 +++++-- tests/unit/test-error-report.c | 17 ----------------- ui/dbus-listener.c | 22 +++++++++++++++------- ui/gtk.c | 6 +++++- ui/qemu-pixman.c | 5 ++++- ui/spice-core.c | 6 ++++-- util/aio-win32.c | 2 +- util/error.c | 5 +---- util/oslib-win32.c | 25 ++++++++++++++++++++----- 22 files changed, 106 insertions(+), 78 deletions(-) -- 2.49.0
