RE: [PATCH v6 03/22] intel_iommu: Update terminology to match VTD spec

[Duan, Zhenzhong]

>-----Original Message-----
>From: Liu, Yi L <yi.l....@intel.com>
>Subject: Re: [PATCH v6 03/22] intel_iommu: Update terminology to match
>VTD spec
>
>On 2025/9/18 16:57, Zhenzhong Duan wrote:
>> VTD spec revision 3.4 released in December 2021 renamed "First-level" to
>> "First-stage" and "Second-level" to "Second-stage".
>>
>> Do the same in intel_iommu code to match spec, change all existing
>> "fl/sl/FL/SL/first level/second level/stage-1/stage-2" terminology to
>> "fs/ss/FS/SS/first stage/second stage".
>>
>> No functional changes intended.
>
>LGTM.
>
>Reviewed-by: Yi Liu <yi.l....@intel.com>
>
>[...]
>
>>
>> -    if (!s->scalable_mode && s->flts) {
>> +    if (!s->scalable_mode && s->fsts) {
>>           error_setg(errp, "x-flts is only available in scalable mode");
>
>just realized we don't have chance to rename x-flts..

Ah, yes.

>
>>           return false;
>>       }
>>
>> -    if (!s->flts && s->aw_bits != VTD_HOST_AW_39BIT &&
>> +    if (!s->fsts && s->aw_bits != VTD_HOST_AW_39BIT &&
>>           s->aw_bits != VTD_HOST_AW_48BIT) {
>>           error_setg(errp, "%s: supported values for aw-bits
>are: %d, %d",
>>                      s->scalable_mode ? "Scalable mode(flts=off)" :
>"Legacy mode",
>> @@ -4877,7 +4879,7 @@ static bool vtd_decide_config(IntelIOMMUState
>*s, Error **errp)
>>           return false;
>>       }
>>
>> -    if (s->flts && s->aw_bits != VTD_HOST_AW_48BIT) {
>> +    if (s->fsts && s->aw_bits != VTD_HOST_AW_48BIT) {
>>           error_setg(errp,
>>                      "Scalable mode(flts=on): supported value for
>aw-bits is: %d",
>
>this should be x-flts=on. right? not a fault of this patch.

Yes, let me fix it in this patch opportunistically.

Thanks
Zhenzhong