On 29/09/2025 22.43, Zhuoying Cai wrote:
Thank you for all the feedback! I'll address the comments in the next
version.
On 9/29/25 9:30 AM, Thomas Huth wrote:
On 18/09/2025 01.21, Zhuoying Cai wrote:
...
+ /* PSW points within a signed binary code component */
+ for (int i = 0; i < range_index; i++) {
+ if (comp_addr_range[i].is_signed &&
+ addr >= comp_addr_range[i].start_addr &&
+ addr <= comp_addr_range[i].end_addr) {
is it still OK if the address points to the end_addr? Or should that be
end_addr - 2 instead (since an opcode has at least two bytes)?
Using end_addr - 2 seems correct, since it accounts for the minimum
instruction length.
Just to clarify: using end_addr - 2 should ensure that at least a 2-byte
instruction fits. Should longer instructions (e.g., 4 and 6 bytes) be a
concern in this context?
No clue ... but I guess it should be fine if the instruction at least starts
in the signed area?
Thomas
