Re: [PATCH v3 2/3] intel_iommu: Reset pasid cache when system level reset

[Yi Liu]

On 2025/10/17 17:36, Zhenzhong Duan wrote:

Reset pasid cache when system level reset. Currently we don't have any
device supporting PASID yet. So all are PASID_0, its vtd_as is allocated
by PCI system and never removed, just mark pasid cache invalid.

Signed-off-by: Yi Liu <yi.l....@intel.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>
---
  hw/i386/intel_iommu.c | 16 ++++++++++++++++
  hw/i386/trace-events  |  1 +
  2 files changed, 17 insertions(+)

Reviewed-by: Yi Liu <yi.l....@intel.com>

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index c47f13b659..07bc0a749c 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -87,6 +87,21 @@ struct vtd_iotlb_key {
  static void vtd_address_space_refresh_all(IntelIOMMUState *s);
  static void vtd_address_space_unmap(VTDAddressSpace *as, IOMMUNotifier *n);

+static void vtd_pasid_cache_reset_locked(IntelIOMMUState *s)

+{
+    VTDAddressSpace *vtd_as;
+    GHashTableIter as_it;
+
+    trace_vtd_pasid_cache_reset();
+
+    g_hash_table_iter_init(&as_it, s->vtd_address_spaces);
+    while (g_hash_table_iter_next(&as_it, NULL, (void **)&vtd_as)) {
+        VTDPASIDCacheEntry *pc_entry = &vtd_as->pasid_cache_entry;
+        pc_entry->valid = false;
+    }
+}
+
+
  static void vtd_define_quad(IntelIOMMUState *s, hwaddr addr, uint64_t val,
                              uint64_t wmask, uint64_t w1cmask)
  {
@@ -381,6 +396,7 @@ static void vtd_reset_caches(IntelIOMMUState *s)
      vtd_iommu_lock(s);
      vtd_reset_iotlb_locked(s);
      vtd_reset_context_cache_locked(s);
+    vtd_pasid_cache_reset_locked(s);
      vtd_iommu_unlock(s);
  }

diff --git a/hw/i386/trace-events b/hw/i386/trace-events

index 298addb24d..b704f4f90c 100644
--- a/hw/i386/trace-events
+++ b/hw/i386/trace-events
@@ -24,6 +24,7 @@ vtd_inv_qi_head(uint16_t head) "read head %d"
  vtd_inv_qi_tail(uint16_t head) "write tail %d"
  vtd_inv_qi_fetch(void) ""
  vtd_context_cache_reset(void) ""
+vtd_pasid_cache_reset(void) ""
  vtd_inv_desc_pasid_cache_gsi(void) ""
  vtd_inv_desc_pasid_cache_dsi(uint16_t domain) "Domain selective PC invalidation 
domain 0x%"PRIx16
  vtd_inv_desc_pasid_cache_psi(uint16_t domain, uint32_t pasid) "PASID selective PC 
invalidation domain 0x%"PRIx16" pasid 0x%"PRIx32