On 10/21/25 08:41, Jamin Lin wrote:
Hi Cédric,
Subject: Re: aspeed: Split the machine definition into individual source files
Hi,
Patch series 1
hw/arm/aspeed_ast1030_evb.c (ast1030-evb) ---> or
hw/arm/aspeed_ast10x0_evb.c, then we can place (ast1030-evb and
ast1060-evb) hw/arm/aspeed_ast27x0_evb.c (ast2700a0-evb,
ast2700a1-evb)
Patch series 2
hw/arm/aspeed_ast2400_palmetto.c (palmetto-bmc)
hw/arm/aspeed_ast2400_quanta-q71l.c (quanta-q71l-bmc)
hw/arm/aspeed_ast2400_supermicrox11.c (supermicrox11-bmc)
Patch series 3
hw/arm/aspeed_ast2500_evb.c (ast2500-evb)
hw/arm/aspeed_ast2500_romulus.c (romulus-bmc)
hw/arm/aspeed_ast2500_sonorapass.c (sonorapass-bmc)
hw/arm/aspeed_ast2500_witherspoon.c (witherspoon-bmc)
hw/arm/aspeed_ast2500_yosemitev2.c (yosemitev2-bmc)
hw/arm/aspeed_ast2500_supermicro-x11spi.c (supermicro-x11spi-bmc)
hw/arm/aspeed_ast2500_fp5280g2.c (fp5280g2-bmc)
hw/arm/aspeed_ast2500_g220a.c (g220a-bmc)
hw/arm/aspeed_ast2500_tiogapass.c (tiogapass-bmc)
Patch series 4
hw/arm/aspeed_ast2600_evb.c (ast2600-evb)
hw/arm/aspeed_ast2600_qcom-dc-scm-v1.c (qcom-dc-scm-v1-b mc)
hw/arm/aspeed_ast2600_qcom-firework-bmc.c (qcom-firework-bmc)
hw/arm/aspeed_ast2600_rainier.c (rainier-bmc)
hw/arm/aspeed_ast2600_fuji.c (fuji-bmc)
hw/arm/aspeed_ast2600_bletchley.c (bletchley-bmc)
hw/arm/aspeed_ast2600_ fby35.c (fby35-bmc)
For the FBY35 platform, since it includes both AST1030 and AST2600, we may
consider renaming the file to:
hw/arm/aspeed_ast1030_ast2600_fby35.c (hw/arm/fby35.c)
Since ast2600 is the main SoC of the fby35, "hw/arm/aspeed_ast2600_fby35.c"
should be a more relevant name.
hw/arm/aspeed_ast2600_ fby35.c (fby35-bmc from aspeed.c)
hw/arm/aspeed_ast2600_fby35.c (hw/arm/fby35.c)
Both them use the same name. Do you mean to move them in one file?
Oh. I forgot that we had 2 machines.
I would leave hw/arm/fby35.c untouched. I am thinking of dropping
the "fby35" machine since it it not maintained and we have another
multi-soc machine: "ast2700fc".
Thanks,
C.
