Re: [PATCH v2 1/3] hw/riscv: Use generic hwaddr for firmware addressses

[Philippe Mathieu-Daudé]

Typo addres[s]ses ;)

On 27/10/25 13:35, Anton Johansson wrote:

Signed-off-by: Anton Johansson <a...@rev.ng>
---
  include/hw/riscv/boot.h    | 20 ++++++++++----------
  hw/riscv/boot.c            | 22 +++++++++++-----------
  hw/riscv/microchip_pfsoc.c |  2 +-
  hw/riscv/sifive_u.c        |  2 +-
  hw/riscv/spike.c           |  4 ++--
  hw/riscv/virt.c            |  2 +-
  6 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h
index 7d59b2e6c6..d835594baa 100644
--- a/include/hw/riscv/boot.h
+++ b/include/hw/riscv/boot.h
@@ -43,21 +43,21 @@ bool riscv_is_32bit(RISCVHartArrayState *harts);
  char *riscv_plic_hart_config_string(int hart_count);

void riscv_boot_info_init(RISCVBootInfo *info, RISCVHartArrayState *harts);

-target_ulong riscv_calc_kernel_start_addr(RISCVBootInfo *info,
-                                          target_ulong firmware_end_addr);
-target_ulong riscv_find_and_load_firmware(MachineState *machine,
-                                          const char *default_machine_firmware,
-                                          hwaddr *firmware_load_addr,
-                                          symbol_fn_t sym_cb);
+hwaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info,
+                                    hwaddr firmware_end_addr);
+hwaddr riscv_find_and_load_firmware(MachineState *machine,
+                                    const char *default_machine_firmware,
+                                    hwaddr *firmware_load_addr,
+                                    symbol_fn_t sym_cb);
  const char *riscv_default_firmware_name(RISCVHartArrayState *harts);
  char *riscv_find_firmware(const char *firmware_filename,
                            const char *default_machine_firmware);
-target_ulong riscv_load_firmware(const char *firmware_filename,
-                                 hwaddr *firmware_load_addr,
-                                 symbol_fn_t sym_cb);
+hwaddr riscv_load_firmware(const char *firmware_filename,
+                           hwaddr *firmware_load_addr,
+                           symbol_fn_t sym_cb);

OK up to here,

  void riscv_load_kernel(MachineState *machine,
                         RISCVBootInfo *info,
-                       target_ulong kernel_start_addr,
+                       hwaddr kernel_start_addr,

but can we have this single change in a distinct patch please,
so we can better describe it than "firmware address" and it
doesn't block the rest?

                         bool load_initrd,
                         symbol_fn_t sym_cb);