Re: [PATCH v3 43/59] accel/hvf: Implement WFI without using pselect()

[Richard Henderson]

On 10/28/25 06:42, Philippe Mathieu-Daudé wrote:

--- a/accel/hvf/hvf-accel-ops.c
+++ b/accel/hvf/hvf-accel-ops.c
@@ -128,14 +128,15 @@ static int hvf_init_vcpu(CPUState *cpu)
      cpu->accel = g_new0(AccelCPUState, 1);

/* init cpu signals */

+    sigset_t unblock_ipi_mask;

Why introduce this?  Surely it's unused...

      struct sigaction sigact;

memset(&sigact, 0, sizeof(sigact));

      sigact.sa_handler = dummy_signal;
      sigaction(SIG_IPI, &sigact, NULL);

- pthread_sigmask(SIG_BLOCK, NULL, &cpu->accel->unblock_ipi_mask);

-    sigdelset(&cpu->accel->unblock_ipi_mask, SIG_IPI);
+    pthread_sigmask(SIG_BLOCK, NULL, &unblock_ipi_mask);
+    sigdelset(&unblock_ipi_mask, SIG_IPI);

... apart from mere initialization.


r~