On Tue, 28 Oct 2025 at 15:41, Philippe Mathieu-Daudé <[email protected]> wrote: > > On 28/10/25 14:10, Peter Maydell wrote: > > On Tue, 28 Oct 2025 at 05:42, Philippe Mathieu-Daudé <[email protected]> > > wrote: > >> > >> Missing review: 15, 18, 26, 32, 33, 38 (up to #41 could be merged) > >> 42, 43 (up to #49 could be merged) > >> 50+ > >> > >> Since v2: > >> - Improve host page size/mask uses (rth) > >> - Remove cpu_test_interrupt in hvf_wfi (rth) > > > > Richard found an issue with patch 32, so I'm going to > > IIUC this is not an issue, just a worry about performance, > whether getpagesize() implementation calls a syscall. > Anyway I'll cache the value locally -- or better, maybe > have qemu_real_host_page_size() doing that --.
I just meant to note "the patch needs some change before it can be applied"; I agree that the changes are minor. -- PMM
