On 29/10/2025 10.55, Ilya Leoshkevich wrote:
On Thu, 2025-10-16 at 19:58 +0200, Ilya Leoshkevich wrote:
v3:
https://lore.kernel.org/qemu-devel/[email protected]/
v3 -> v4: Add a patch for the missing address generation affecting
interrupts. Slightly adjust the test, keep Thomas' R-b.
Add Thomas' R-b to the timer rearm fix.
v2:
https://lore.kernel.org/qemu-devel/[email protected]/
v2 -> v3: Rearm the timer on control register load (Thomas).
Add Thomas' R-b to the test.
v1:
https://lore.kernel.org/qemu-devel/[email protected]/
v1 -> v2: Add Thomas' R-b.
Cc: stable (Michael).
Improve formatting, commit messages, and test (Ilya).
Hi,
While trying to reproduce [1], I found two bugs in the clock
comparator
handling. This series fixes all three issues and adds a test.
[1]
https://lore.kernel.org/lkml/[email protected]/
Best regards,
Ilya
Ilya Leoshkevich (4):
target/s390x: Fix missing interrupts for small CKC values
target/s390x: Fix missing clock-comparator interrupts after reset
target/s390x: Use address generation for register branch targets
tests/tcg/s390x: Test SET CLOCK COMPARATOR
target/s390x/tcg/mem_helper.c | 11 ++++-
target/s390x/tcg/misc_helper.c | 12 +++--
target/s390x/tcg/translate.c | 11 +++--
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/sckc.S | 63
+++++++++++++++++++++++++
5 files changed, 89 insertions(+), 9 deletions(-)
create mode 100644 tests/tcg/s390x/sckc.S
Hello,
I would like to ping this series.
Patches 1, 2, and 4 are already reviewed (thanks, Thomas!).
Patch 3 still needs a review.
Hi Ilya,
I still got it on my radar, and indeed, it would be great to get an Ack from
Richard or David for patch 3.
However, the main problem is that we need the fix for the C23 problem in the
fourth patch first before this could get merged
(https://gitlab.com/qemu-project/SLOF/-/merge_requests/2). It should
hopefully get fixed with Harsh's next ppc pull request, see:
https://lore.kernel.org/qemu-devel/[email protected]
Thomas
