On Thu, Oct 23, 2025 at 8:40 PM Kevin Wolf <[email protected]> wrote: > > Am 03.09.2025 um 09:57 hat Clément Chigot geschrieben: > > This allows to handle the default FAT size in a single place and make the > > following part taking care only about size parameters. It will be later > > moved away in a specific function. > > > > Setting a floppy disk of 1MB is no longer possible as it was a side > > effect of passing "fat-type=12". To be precise there were three cases: > > - fat-type undefined (aka default): a fat12 2MB disk > > - fat-type=16: a fat16 2Mb disk > > - fat-type=12: a fat12 1Mb disk > > That's quite a strange interface! > > If we're touching it anyway, I would change it to make the more common > format (1.44 MB) the default for FAT12 and make the 2.88 MB FAT12 floppy > temporarily unavailable and later require an explicit size. This way > both sizes would still be available using the fat-type.
I'm a bit hesitant to change the default behavior as people might be using it without clear knowledge of it. True, "floppy" is probably not a widely used feature but still. Do QEMU have some specific guidelines when changing such default behavior ? Adding a warning ? Or just a comment in the changelog would be enough ? > Please say 1.44 MB and 2.88 MB in the commit message rather than 1MB (or > even 1Mb, which might mean megabit). There were other sizes like 1.2 MB > that are closer to 1 MB, so it's better to avoid that confusion. > > > Now, that fat-type undefined means fat-type=2, it's no longer possible > > s/2/12/ > > > to make that size distinction. It will be added back a bit later, > > through the size parameter. > > > > Signed-off-by: Clément Chigot <[email protected]> > > The code looks good, apart from the change I suggested above (making > 1.44 MB the default for FAT12). > > Kevin >
