On Wed, Oct 29, 2025 at 09:15:14AM +0100, Thomas Huth wrote:
> Date: Wed, 29 Oct 2025 09:15:14 +0100
> From: Thomas Huth <[email protected]>
> Subject: [PATCH] tests/functional/x86_64/test_acpi_bits: Silence warnings
>  reported by pylint
> 
> From: Thomas Huth <[email protected]>
> 
> Pylint complains about too many positional arguments for the __init__
> function of the QEMUBitsMachine class, use a "*" to enforce argument
> passing by names instead (which the calling sites are doing here already).
> 
> Second, use lazy logging when calling self.log.info() with a "%s" format
> string, and drop a superfluous "else:" that is not necessary after a
> "raise" statement.
> 
> Signed-off-by: Thomas Huth <[email protected]>
> ---
>  tests/functional/x86_64/test_acpi_bits.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

LGTM,

Reviewed-by: Zhao Liu <[email protected]>


Reply via email to