On 28/10/2025 23.03, John Snow wrote:
This group is intended for packages required to run "make check"
successfully. Once qemu.qmp is fully divorced from the source tree, this
will primarily mean the qemu.qmp package. It specifically excludes
packages only needed to run the functional tests, which are not invoked
by default for "make check".
Signed-off-by: John Snow <[email protected]>
---
pythondeps.toml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/pythondeps.toml b/pythondeps.toml
index 3d6907af799..70e83320855 100644
--- a/pythondeps.toml
+++ b/pythondeps.toml
@@ -31,6 +31,9 @@ meson = { accepted = ">=1.9.0", installed = "1.9.0", canary =
"meson" }
sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = "sphinx-build"
}
sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
+[tests]
+qemu_qmp = { accepted = ">=0.0.5", installed = "0.0.5" }
+
[functests]
qemu_qmp = { accepted = ">=0.0.5", installed = "0.0.5" }
pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
Hmm, "tests" is a string that is very hard to grep for, since it's used all
over the place. Could we maybe continue to call this section "testdeps" or
something else that is more unique?
Also, could the qemu_qmp be removed from the [functests] section now? As
long as the python/qemu/qmp folder has not been removed yet, it should not
be necessary - and as soon as it has been removed, the generic venv from
"[tests]" should be in place, shouldn't it?
So maybe you could merge this patch with the previous one, simplifying the
change here to something like this:
diff --git a/pythondeps.toml b/pythondeps.toml
--- a/pythondeps.toml
+++ b/pythondeps.toml
@@ -33,4 +33,6 @@ sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" }
[testdeps]
qemu_qmp = { accepted = ">=0.0.5", installed = "0.0.5" }
+
+[functests]
pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" }
?
Thomas
