On Thu, Oct 30, 2025 at 11:13:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Remove the 'patch prefix exists, appears to be a -p0 patch' warning > entirely as it is fundamentally flawed and can only produce false > positives. > > Sometimes I create test files with names 'a' and 'b', and then get > surprised seeing this warning. It was not easy to understand where it > comes from. > > How it works: > 1. It extracts prefixes (a/, b/) from standard diff output > 2. Checks if files/directories with these names exist in the project > root > 3. Warns if they exist, claiming it's a '-p0 patch' issue > > This logic is wrong because: > - Standard diff/patch tools always use a/ and b/ prefixes by default > - The existence of files named 'a' or 'b' in the working directory is > completely unrelated to patch format > - The working directory state may not correspond to the patch content > (different commits, branches, etc.) > - In QEMU project, there are no single-letter files/directories in root, > so this check can only generate false positives > > The correct way to detect -p0 patches would be to analyze the path > format within the patch itself (e.g., absolute paths or paths without > prefixes), not check filesystem state. > > So, let's finally drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> > --- > scripts/checkpatch.pl | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
