On Fri, Oct 31, 2025 at 04:52:50PM -0700, Nicolin Chen wrote:
> On Fri, Oct 31, 2025 at 10:49:46AM +0000, Shameer Kolothum wrote:
> > +smmuv3_accel_install_nested_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\
> [...]
> > + config = STE_CONFIG(&ste);
> > + if (!STE_VALID(&ste) || !STE_CFG_S1_ENABLED(config)) {
> > + if (!smmuv3_accel_dev_uninstall_nested_ste(accel_dev,
> > + STE_CFG_ABORT(config),
>
> This smmuv3_accel_uninstall_nested_ste() feels a bit redundant now.
>
> Perhaps we could try something like this:
>
> #define accel_dev_to_smmuv3(dev) ARM_SMMUV3(&dev->sdev.smmu)
Oops. This should be:
#define accel_dev_to_smmuv3(dev) ARM_SMMUV3((SMMUState *)dev->sdev.smmu)
But it doesn't seem to be very useful anyway. So, feel free to
keep it inline or just drop it :)
Nicolin
