CC @Yan Vugenfirer <[email protected]> Best Regards, Kostiantyn Kostiuk.
On Mon, Nov 3, 2025 at 9:30 AM Kostiantyn Kostiuk <[email protected]> wrote: > > This function is used inside Windows headers. You can find the following > code in comutil.h in MinGW > > inline _bstr_t::Data_t::Data_t(const char *s) : m_str(NULL),m_RefCount(1) > { > m_wstr = _com_util::ConvertStringToBSTR(s); > } > > But MinGW does not implement ConvertStringToBSTR, so QEMU should implement > this function. > We use _bstr_t in VSS-provided DLL, so this function is mandatory for us. > > > Best Regards, > Kostiantyn Kostiuk. > > > On Sat, Nov 1, 2025 at 3:13 PM Peter Maydell <[email protected]> > wrote: > >> On Sat, 1 Nov 2025 at 13:04, Bernhard Beschow <[email protected]> wrote: >> > >> > Now that MSYS2 provides an implementation of the function it clashes >> with >> > QEMU's, resulting in a compilation error. Remove it since it doesn't >> seem >> > to be used anyway. >> >> The comment says it's used by _bstr_t, which presumably >> is in some Windows header or library that we're linking against. >> Our code seems to use _bstr_t a lot. Is this function definitely >> not required, or should we have something so we provide it only >> when MSYS2 does not? >> >> thanks >> -- PMM >> >>
