On Mon, Nov 03, 2025 at 10:42:31AM +0100, Igor Mammedov wrote: > Date: Mon, 3 Nov 2025 10:42:31 +0100 > From: Igor Mammedov <[email protected]> > Subject: Re: [PATCH v5] hw/i386/pc: Remove > PCMachineClass::legacy_cpu_hotplug field > X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) > > On Sat, 1 Nov 2025 00:27:36 +0100 (CET) > BALATON Zoltan <[email protected]> wrote: > > [...] > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > > > b/tests/qtest/bios-tables-test-allowed-diff.h > > > index dfb8523c8b..7191854857 100644 > > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > > @@ -1 +1,43 @@ > > > > Does this belong here? > thanks for spotting it, it should be a separate preceding patch,
Thanks! I think I see :-) - I should follow the gudience in tests/qtest/bios-tables-test.c, to split this patch. > and then expected blobs update patch after this patch, > that would cleanup bios-tables-test-allowed-diff.h along with new blobs. > /i.e. as per process described in bios-tables-test.c / Regards, Zhao
