On 7/11/25 16:41, Peter Maydell wrote:
If the guest incorrectly programs the lm4549 audio chip with a zero
frequency, we will pass this to AUD_open_out(), which will complain:

    A bug was just triggered in AUD_open_out
    Save all your work and restart without audio
    I am sorry
    Context:
    audio: frequency=0 nchannels=2 fmt=S16 endianness=little

The datasheet doesn't say what we should do here, only that the valid
range for the freqency is 8000 to 48000 Hz; we choose to log the
guest error and ignore an attempt to change the DAC rate to something
outside the valid range.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/410
Signed-off-by: Peter Maydell <[email protected]>
---
This bug has been around for so long and is a weird edge case whose
only effect is to print a debug message, so it doesn't really seem
worth cc'ing stable on.
---
  hw/audio/lm4549.c | 17 ++++++++++++++++-
  1 file changed, 16 insertions(+), 1 deletion(-)

With s/8000/4000/ in description:
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>


Reply via email to