On Wed, Nov 12, 2025 at 02:41:34PM +0100, Philippe Mathieu-Daudé wrote: > Describe the @c (this is the *frontend*) and @s (the *backend*) > parameters. Fill qemu_chr_fe_[gs]et_msgfds() method docstrings. > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > include/chardev/char-fe.h | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h > index 5f8a6df17dc..36bcf1f88a6 100644 > --- a/include/chardev/char-fe.h > +++ b/include/chardev/char-fe.h
> > /** > * qemu_chr_fe_get_msgfd: > + * @c: the character frontend to access > * > * For backends capable of fd passing, return the latest file descriptor > passed > * by a client. > @@ -286,9 +302,12 @@ int qemu_chr_fe_get_msgfd(CharFrontend *c); We should note here that if there is more than 1 pending FD, all except the first pending FD will be closed > > /** > * qemu_chr_fe_get_msgfds: > + * @c: the character frontend > + * @fds: an array of ancillary file descriptors to get > + * @num: the maximum number of ancillary file descriptors to get in @fds > * > * For backends capable of fd passing, return the number of file received > - * descriptors and fills the fds array up to num elements > + * descriptors and fills the fds array up to @num elements Here we should note that if there are more pending FDs than @num, then all further FDs will be closed. > * > * Returns: -1 if fd passing isn't supported or there are no pending file > * descriptors. If file descriptors are returned, subsequent calls > to Those are minor changes, so consider this tohave Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
