On 13.11.25 16:56, Eric Blake wrote:
On Thu, Nov 13, 2025 at 09:49:35AM +0300, Vladimir Sementsov-Ogievskiy wrote:
Test, that fix in previous commit make sense.
"previous commit" is ambiguous, when this patch is not part of a
larger series. Maybe use the term "recent commit" and call out its
title and/or commit hash?
Good caught! So we need to rewrite first line into
Test for the fix in recent commit
20aa05ed "util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic"
+++ b/tests/unit/test-cutils.c
@@ -3626,6 +3626,44 @@ static void test_si_prefix(void)
g_assert_cmpstr(si_prefix(18), ==, "E");
}
+static void test_qemu_hexdump_alignment(void)
+{
+ /*
+ * Test that ASCII part is properly aligned for incomplete lines.
+ * This test catches the bug that was fixed in previous commit
+ * "util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic".
Ah - that's the line I was expecting in the commit message; and I
found commit 20aa05ed from there.
--
Best regards,
Vladimir
