On 11/17/25 15:13, Matthew Lugg wrote:
On 10/20/25 16:26, Peter Maydell wrote:
I was going to complain about indent on this line, but the
problem seems to be that the file is incorrectly
indented with hardcoded tabs for parts of it.
Oops! I mostly work in a language where my editor config forces space
indentation, so occasionally forget to set space indentation when I do
need to. Will correct (and double-check indentation in the rest of the
series) in the next revision.
While working on this commit I just realised that you meant that
*existing* parts of the file were indented with hard tabs (causing the
apparent mismatch in the patch). Because there are quite a few hard tabs
in the file, I'll leave them as-is to avoid a big whitespace diff, but
will keep my added line correctly space-indented, as in the original
patch. You (or whoever is involved in the final merge) can of course add
a patch to fix the existing whitespace if you want.
