On Mon, Nov 17, 2025 at 10:12:53AM +0100, Philippe Mathieu-Daudé wrote:
> While registering the ARM/Aarch64 machine interfaces
> in commit 38c5ab40031 ("hw/arm: Filter machine types
> for qemu-system-arm/aarch64 binaries"), we missed the
> XenPV machine. Correct that.
>
> Reported-by: Edgar E. Iglesias <[email protected]>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> Tested-by: Edgar E. Iglesias <[email protected]>
Reviewed-by: Edgar E. Iglesias <[email protected]>
> ---
> 1/ Review got likely unnoticed by Xen folks because no
> Xen-specific entry in MAINTAINERS:
>
> $ ./scripts/get_maintainer.pl -f hw/arm/xen-pvh.c
> Peter Maydell <[email protected]> (maintainer:ARM TCG CPUs)
> [email protected] (open list:ARM TCG CPUs)
> [email protected] (open list:All patches CC here)
>
> 2/ Should we restrict it to aa64 only?
> ---
> hw/arm/xen-pvh.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
> index 1a9eeb01c8e..86a02966161 100644
> --- a/hw/arm/xen-pvh.c
> +++ b/hw/arm/xen-pvh.c
> @@ -10,6 +10,7 @@
> #include "hw/boards.h"
> #include "system/system.h"
> #include "hw/xen/xen-pvh-common.h"
> +#include "hw/arm/machines-qom.h"
>
> #define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh")
>
> @@ -95,6 +96,7 @@ static const TypeInfo xen_arm_machine_type = {
> .class_init = xen_arm_machine_class_init,
> .instance_size = sizeof(XenPVHMachineState),
> .instance_init = xen_arm_instance_init,
> + .interfaces = arm_aarch64_machine_interfaces,
> };
>
> static void xen_arm_machine_register_types(void)
> --
> 2.51.0
>
