On Tue, Nov 18, 2025, 5:01 AM Thomas Huth <[email protected]> wrote:
> On 17/11/2025 19.51, John Snow wrote: > > pygdbmi is only needed for functional tests and not tests in general; to > > prepare for more universally required test dependencies, rename this > > dependency group "functests" instead. > > > > In other words: we promise that "make check" will run offline in an > > isolated environment, but we do not make the same promises for > > functional tests, which require an internet connection. > > > > Signed-off-by: John Snow <[email protected]> > > --- > > pythondeps.toml | 2 +- > > tests/Makefile.include | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/pythondeps.toml b/pythondeps.toml > > index 1657953ff65..d814bb54d08 100644 > > --- a/pythondeps.toml > > +++ b/pythondeps.toml > > @@ -31,6 +31,6 @@ meson = { accepted = ">=1.9.0", installed = "1.9.0", > canary = "meson" } > > sphinx = { accepted = ">=3.4.3", installed = "6.2.1", canary = > "sphinx-build" } > > sphinx_rtd_theme = { accepted = ">=0.5", installed = "1.2.2" } > > > > -[testdeps] > > +[functests] > > "qemu.qmp" = { accepted = ">=0.0.5", installed = "0.0.5" } > > pygdbmi = { accepted = ">=0.11.0.0", installed = "0.11.0.0" } > > diff --git a/tests/Makefile.include b/tests/Makefile.include > > index d4dfbf3716d..6f86eb283d3 100644 > > --- a/tests/Makefile.include > > +++ b/tests/Makefile.include > > @@ -98,7 +98,7 @@ quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \ > > > > $(TESTS_VENV_TOKEN): $(SRC_PATH)/pythondeps.toml > > $(call quiet-venv-pip,install -e "$(SRC_PATH)/python/") > > - $(MKVENV_ENSUREGROUP) $< testdeps > > + $(MKVENV_ENSUREGROUP) $< functests > > $(call quiet-command, touch $@) > > > > check-venv: $(TESTS_VENV_TOKEN) > > I'd maybe merge this with the next patch. Anyway: > Easy enough, sure! > Reviewed-by: Thomas Huth <[email protected]> > Thanks!
