On Wed, Nov 19, 2025 at 4:27 AM Thomas Huth <[email protected]> wrote:
>
> On 17/11/2025 19.51, John Snow wrote:
> > Begin relying on the external python-qemu-qmp dependency instead, to
> > prevent desync between the internal and external libraries.
> >
> > Signed-off-by: John Snow <[email protected]>
> > ---
> ...
> > diff --git a/python/qemu/utils/qom_fuse.py b/python/qemu/utils/qom_fuse.py
> > index cf7e344bd53..e377ef6942f 100644
> > --- a/python/qemu/utils/qom_fuse.py
> > +++ b/python/qemu/utils/qom_fuse.py
> > @@ -47,7 +47,6 @@
> >
> >   import fuse
> >   from fuse import FUSE, FuseOSError, Operations
> > -
> >   from qemu.qmp import ExecuteError
> >
> >   from .qom_common import QOMCommand
>
> Nit: The above change looks unrelated.

It's actually related! "qemu.qmp" goes from being a "second party"
package to a "third party" package because of the removal. Thus, it
gets regrouped with other third party packages in the import order.

The import order is:

- first party (python stdlib)
- third party (PyPI stuff)
- second party (local imports, different package)
- local imports (local imports, same package)

>
> Apart from that:
> Reviewed-by: Thomas Huth <[email protected]>
>


Reply via email to