On 12/2/25 11:58, Philippe Mathieu-Daudé wrote:
On 2/12/25 02:12, Richard Henderson wrote:
For native code generation, zero-extending 32-bit addresses for
the slow path helpers happens in tcg_out_{ld,st}_helper_args,
but there isn't really a slow path for TCI, so that didn't happen.
Make the extension for TCI explicit in the opcode stream,
much like we already do for plugins and atomic helpers.
Fixes: 24e46e6c9d9 ("accel/tcg: Widen tcg-ldst.h addresses to uint64_t")
Signed-off-by: Richard Henderson <[email protected]>
---
tcg/tcg-op-ldst.c | 222 ++++++++++++++++++++++------------------------
1 file changed, 107 insertions(+), 115 deletions(-)
Was slightly simpler to review with preliminary patch 1.5 posted
(consider taking it in between). Anyway:
I hadn't been moving maybe_{extend,free}_addr64 at all, but replacing them.
But yes, this larger patch could be usefully refactored.
r~
