On 12/11/25 10:16, Zhao Liu wrote:
On Thu, Dec 11, 2025 at 09:08:33AM +0100, Paolo Bonzini wrote:
Great, thanks! Just one question, should the CPUID feature be "apx" or
"apxf" (and therefore CPUID_7_1_EDX_APXF)? I can fix that myself of course.
Good point! I didn't realize this.
1) Per APX spec:
(APX adds) CPUID Enumeration for APX_F (APX Foundation).
2) And gcc also use apx_f:
https://codebrowser.dev/gcc/gcc/config/i386/cpuid.h.html#_M/bit_APX_F
3) ...and we already have "avx512f".
So you're right, I should use "apxf" and CPUID_7_1_EDX_APXF.
Since APX CPUID appears in several patches, I can respin a new version
quickly.
No problem, I have done a quick pass with "sed" on the patches and
reapplied them. I do ask you to respin the Diamond Rapids series
though, on top of the for-upstream tag of
https://gitlab.com/bonzini/qemu (currently going through CI).
Applied for 11.0!
Paolo
