Re: [PATCH v3 03/12] kvm: Provide explicit error for kvm_create_guest_memfd()

[Xiaoyao Li]

On 12/16/2025 4:51 AM, Peter Xu wrote:

So that there will be a verbal string returned when kvm not enabled, or kvm
not compiled.

Signed-off-by: Peter Xu <pet...@redhat.com>

Reviewed-by: Xiaoyao Li <xiaoyao...@intel.com>

---
  accel/kvm/kvm-all.c    | 5 +++++
  accel/stubs/kvm-stub.c | 1 +
  2 files changed, 6 insertions(+)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 68d57c1af0..c32fbcf9cc 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -4492,6 +4492,11 @@ int kvm_create_guest_memfd(uint64_t size, uint64_t 
flags, Error **errp)
          .flags = flags,
      };

+ if (!kvm_enabled()) {

+        error_setg(errp, "guest-memfd requires KVM accelerator");
+        return -1;
+    }
+
      if (!kvm_guest_memfd_supported) {
          error_setg(errp, "KVM does not support guest_memfd");
          return -1;
diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c
index 73f04eb589..01b1d6285e 100644
--- a/accel/stubs/kvm-stub.c
+++ b/accel/stubs/kvm-stub.c
@@ -123,6 +123,7 @@ bool kvm_hwpoisoned_mem(void)

int kvm_create_guest_memfd(uint64_t size, uint64_t flags, Error **errp)

  {
+    error_setg(errp, "KVM is not enabled");
      return -ENOSYS;
  }