On 15/12/2025 11.19, Cédric Le Goater wrote:
A recent change in glibc 2.42.9000 [1] changes the return type of strstr() and other string functions to be 'const char *' when the input is a 'const char *'. This breaks the build in :../gdbstub/user.c:322:21: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 322 | pid_placeholder = strstr(path, "%d"); | ^ Fix this by changing the type of the variables that store the result of these functions to 'const char *'. [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=cd748a63ab1a7ae846175c532a3daab341c62690 Signed-off-by: Cédric Le Goater <[email protected]> --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 2e14ded3f01053d4d4a36426c509ce7a6b81cb67..e233c598165ca1b10a5f2a89c87136df9af636ca 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -317,7 +317,7 @@ static bool gdb_accept_socket(int gdb_fd) static int gdbserver_open_socket(const char *path, Error **errp) { g_autoptr(GString) buf = g_string_new(""); - char *pid_placeholder; + const char *pid_placeholder;pid_placeholder = strstr(path, "%d");if (pid_placeholder != NULL) {
Reviewed-by: Thomas Huth <[email protected]>
