I don't want to admit how many hours I spent trying to figure out why nothing was being printed (as the enable-ing code hadn't yet run, even thought it existed).
Signed-off-by: julia <[email protected]> --- hw/char/cmsdk-apb-uart.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/char/cmsdk-apb-uart.c b/hw/char/cmsdk-apb-uart.c index 32090f3516f6accad32bcd9fe9b10d572f17ed12..26931ab6c5d36f0ec5aac7acf3677855a6dd5f22 100644 --- a/hw/char/cmsdk-apb-uart.c +++ b/hw/char/cmsdk-apb-uart.c @@ -159,6 +159,10 @@ static uint64_t uart_read(void *opaque, hwaddr offset, unsigned size) switch (offset) { case A_DATA: r = s->rxbuf; + if (!(s->ctrl & R_CTRL_RX_EN_MASK)) { + qemu_log_mask(LOG_GUEST_ERROR, + "CMSDK APB UART: receive data read with Rx disabled\n"); + } s->state &= ~R_STATE_RXFULL_MASK; cmsdk_apb_uart_update(s); qemu_chr_fe_accept_input(&s->chr); @@ -248,6 +252,10 @@ static void uart_write(void *opaque, hwaddr offset, uint64_t value, switch (offset) { case A_DATA: s->txbuf = value; + if (!(s->ctrl & R_CTRL_TX_EN_MASK)) { + qemu_log_mask(LOG_GUEST_ERROR, + "CMSDK APB UART: transmit data write with Tx disabled\n"); + } if (s->state & R_STATE_TXFULL_MASK) { /* Buffer already full -- note the overrun and let the * existing pending transmit callback handle the new char. --- base-commit: 7154e4df40468012fccb6687ecd2b288c56a4a2d change-id: 20251217-cmsdk-uart-disabled-warning2-0072a44c2ea1 Best regards, -- julia <[email protected]>
