On Wed, Dec 24, 2025 at 3:47 PM Philippe Mathieu-Daudé <[email protected]> wrote: > > The PL011 component is only built / used by ARM targets, which > are only built in little endianness. Thus we only ever built > as little endian, never testing the big-endian possibility of > the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping > the little endian variant. > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > Reviewed-by: Richard Henderson <[email protected]> > ---
FWIW Reviewed-by: Manos Pitsidianakis <[email protected]> > hw/char/pl011.c | 2 +- > rust/hw/char/pl011/src/device.rs | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/char/pl011.c b/hw/char/pl011.c > index 01335d9437d..97cd9bd4c54 100644 > --- a/hw/char/pl011.c > +++ b/hw/char/pl011.c > @@ -538,7 +538,7 @@ static void pl011_clock_update(void *opaque, ClockEvent > event) > static const MemoryRegionOps pl011_ops = { > .read = pl011_read, > .write = pl011_write, > - .endianness = DEVICE_NATIVE_ENDIAN, > + .endianness = DEVICE_LITTLE_ENDIAN, > .impl.min_access_size = 4, > .impl.max_access_size = 4, > }; > diff --git a/rust/hw/char/pl011/src/device.rs > b/rust/hw/char/pl011/src/device.rs > index 04155dabe1a..a6227a99f30 100644 > --- a/rust/hw/char/pl011/src/device.rs > +++ b/rust/hw/char/pl011/src/device.rs > @@ -495,7 +495,7 @@ unsafe fn init(mut this: ParentInit<Self>) { > static PL011_OPS: MemoryRegionOps<PL011State> = > MemoryRegionOpsBuilder::<PL011State>::new() > .read(&PL011State::read) > .write(&PL011State::write) > - .native_endian() > + .little_endian() > .impl_sizes(4, 4) > .build(); > > -- > 2.52.0 >
