On Wed, Dec 24, 2025 at 5:24 PM Philippe Mathieu-Daudé
<[email protected]> wrote:
>
> Guard the native endian APIs we want to remove by surrounding
> them with TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API #ifdef'ry.
>
> Since all targets can check the definition, do not poison it.
>
> Once a target gets cleaned we'll set the definition in the
> target config, then the target won't be able to use the legacy
> API anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> ---

Reviewed-by: Manos Pitsidianakis <[email protected]>

>  include/system/memory_ldst_phys.h.inc | 2 ++
>  scripts/make-config-poison.sh         | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/include/system/memory_ldst_phys.h.inc 
> b/include/system/memory_ldst_phys.h.inc
> index f4c91dc7a91..66bbd3061c2 100644
> --- a/include/system/memory_ldst_phys.h.inc
> +++ b/include/system/memory_ldst_phys.h.inc
> @@ -31,8 +31,10 @@ static inline void glue(stb_phys, SUFFIX)(ARG1_DECL, 
> hwaddr addr, uint8_t val)
>                                      MEMTXATTRS_UNSPECIFIED, NULL);
>  }
>
> +#ifndef TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API
>  #define ENDIANNESS
>  #include "system/memory_ldst_phys_endian.h.inc"
> +#endif /* TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API */
>
>  #define ENDIANNESS  _le
>  #include "system/memory_ldst_phys_endian.h.inc"
> diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
> index 937357b3531..b4d61e8bc9e 100755
> --- a/scripts/make-config-poison.sh
> +++ b/scripts/make-config-poison.sh
> @@ -11,6 +11,7 @@ exec sed -n \
>    -e '/CONFIG_USER_ONLY/d' \
>    -e '/CONFIG_SOFTMMU/d' \
>    -e '/TARGET_NOT_USING_LEGACY_LDST_PHYS_API/d' \
> +  -e '/TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API/d' \
>    -e '/^#define / {' \
>    -e    's///' \
>    -e    's/ .*//' \
> --
> 2.52.0
>

Reply via email to