On 2025/12/24 22:47, BALATON Zoltan wrote:
On Wed, 24 Dec 2025, Akihiko Odaki wrote:
On 2025/12/24 6:49, BALATON Zoltan wrote:
Our documentation says that memory regions are automatically freed
when the owner dies and the reference counting to do this is also
implemented. However this relies on the QOM free funtion that can only
be set by creating objects with object_new but memory API only
provides constructors that call object_initialize which clears the
free function that prevents QOM to manage the memory region lifetime.
Implement corresponding memory_region_new_* functions that do the same
as the memory_region_init_* functions but create the memory region
with object_new so the lifetime can be automatically managed by QOM as
documented.
The documentation explains the existing functions so the discrepancy
between them you see should be fixed by updating them, not adding new
ones.
Do you mean replacing memory_region_init_* with these
memory_region_new_* functions? The memory_region_init_* is still useful
for embedded memory regions that are managed by some other way which is
also mentioned in the documentation as an alternative so I think both of
them are useful for different cases. If you mean we need to update docs
to refer to memory_region_new instead of memory_region_init at some
places then I think you're right, the docs may also need to be updated
or clarified.
I'd like to see a correspondence between the stated problem and the
solution. If the intention is to solve the mismatched documentation and
implementation, I think there are only two possible options:
1) Update the documentation and/or the implementation.
2) Delete them.
But this patch series does neither of them. Replacing
memory_region_init_* with memory_region_new_* does solve as it will do
2) in the process. An alternative solution that implements 1) or 2) is
necessary if it's not ideal.
Regards,
Akihiko Odaki
